chore(dependabot): hold the majors that break the build - #617
Merged
Conversation
TypeScript 7 was never encoded as held, so Dependabot kept proposing it in
the grouped dev-dependencies PR. typescript-eslint refuses to load against
TS 7 ("typescript-eslint does not support TS 7.0"), so `eslint .` exits
before a single test runs and the required Test check fails — the PR is
dead on arrival every week. #606 was the latest.
undici 8 and BullMQ 6 are held for the same reason: deliberately deferred
majors that only produce unmergeable PRs until someone takes them on
purpose. ESLint was already covered.
@changesets/cli is deliberately NOT listed. main took Changesets 3 in #593
and the 1.0 graduation merge reverted it to ^2.31.1 as a side effect of
taking beta's tree; whether that revert stands is a real decision, not
something to cement here.
4 tasks
therealbrad
added a commit
that referenced
this pull request
Sep 8, 2026
#616 pinned conventional-changelog-conventionalcommits to ^9.3.1 to unbreak the release pipeline, and Dependabot immediately proposed ^10.4.0 again in the next dev-dependencies group (#620). Merging that would restore the exact failure #616 fixed: the 10.x line requires conventional-changelog-writer@9, semantic-release 25 bundles a generator depending on writer ^8, and generateNotes dies before any release is cut. The hold was missing from the batch added in #617 — an oversight, since #616 had pinned it minutes earlier.
Contributor
Author
|
🎉 This PR is included in version 1.0.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
therealbrad
added a commit
that referenced
this pull request
Sep 8, 2026
TypeScript 7 was never encoded as held, so Dependabot kept proposing it in
the grouped dev-dependencies PR. typescript-eslint refuses to load against
TS 7 ("typescript-eslint does not support TS 7.0"), so `eslint .` exits
before a single test runs and the required Test check fails — the PR is
dead on arrival every week. #606 was the latest.
undici 8 and BullMQ 6 are held for the same reason: deliberately deferred
majors that only produce unmergeable PRs until someone takes them on
purpose. ESLint was already covered.
@changesets/cli is deliberately NOT listed. main took Changesets 3 in #593
and the 1.0 graduation merge reverted it to ^2.31.1 as a side effect of
taking beta's tree; whether that revert stands is a real decision, not
something to cement here.
(cherry picked from commit 40ed7f7)
therealbrad
added a commit
that referenced
this pull request
Sep 8, 2026
#616 pinned conventional-changelog-conventionalcommits to ^9.3.1 to unbreak the release pipeline, and Dependabot immediately proposed ^10.4.0 again in the next dev-dependencies group (#620). Merging that would restore the exact failure #616 fixed: the 10.x line requires conventional-changelog-writer@9, semantic-release 25 bundles a generator depending on writer ^8, and generateNotes dies before any release is cut. The hold was missing from the batch added in #617 — an oversight, since #616 had pinned it minutes earlier. (cherry picked from commit fbf0893)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TypeScript 7 was never encoded as a held major, so Dependabot keeps proposing it inside the grouped dev-dependencies PR.
typescript-eslinthard-refuses to load against it:so
eslint .exits before a single test runs and the requiredTestcheck fails. The PR is dead on arrival every week — #606 was the most recent, bumping TS5.9.3 -> 7.0.2across the six non-app workspaces.Adds major-ignores for
typescript,undici, andbullmq— the deferred majors that currently only produce unmergeable PRs. ESLint and@eslint/jswere already covered.Type of Change
How Has This Been Tested?
YAML parses and the ignore list resolves to eight entries. Effect is verifiable on the next scheduled Dependabot run — grouped dev-dependency PRs should stop carrying TS 7.
Checklist
Additional Notes
@changesets/cliis deliberately not in this list.maintook Changesets 3 in #593, and the 1.0 graduation merge reverted it to^2.31.1as a side effect of taking beta's tree wholesale. Whether that revert stands is a real decision — the currentchangesets/action@v1+ CLI v2 pairing is internally consistent and published the 1.0.0 packages fine, but it undoes a merged PR that Dependabot originally drove. Cementing it with an ignore rule would settle that by accident.Minor/patch updates for all three ignored packages continue to flow normally; only majors are held.